Fixing regression to detect actions with an explicit extension set - #2047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #2046
Description
A previous PR made an update to auto-detect routes based on extensions used in the request.
If a request came in for
/reports.json, it would look for an action with/reportsthat allowed the JSON mime-type.If a request came in for
/reports.csv, then it would find the action with/reportsthat allowed the CSV mime-type.However, if you defined your action as
/reports.jsonexplicitly, it would be a 404 🤦♂️ This PRkeeps the new auto-detect but also fixes the regression. The downside is that if you rely on the auto-detect now,
it'll technically be 2 route lookups. In the end, correctness is higher priority than performance. We can look at
doing a refactor later that maybe fixes the original issue without breaking compatibility or something.
Checklist
crystal tool format spec src./script/setup./script/test