Skip to content

feat: Migrate definitely typed types into core web sdk - #1266

Open
rmi22186 wants to merge 8 commits into
workstation/3.0-release-2from
feat/web-sdk-owned-types-workstation-v3
Open

feat: Migrate definitely typed types into core web sdk#1266
rmi22186 wants to merge 8 commits into
workstation/3.0-release-2from
feat/web-sdk-owned-types-workstation-v3

refactor(types): hide base sdk interface

d37d844
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 15, 2026 in 24m 15s

Quality Gate failed

Failed conditions
29.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check failure on line 41 in test/types/internal-consumer.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of the "void" operator. 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgyVzgvZm-J9EGcY&open=AZ4tGgyVzgvZm-J9EGcY&pullRequest=1266

Check failure on line 74 in test/types/internal-consumer.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of the "void" operator. 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgyVzgvZm-J9EGch&open=AZ4tGgyVzgvZm-J9EGch&pullRequest=1266

Check warning on line 112 in test/types/definitely-typed/manager.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "user". 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgyrzgvZm-J9EGcm&open=AZ4tGgyrzgvZm-J9EGcm&pullRequest=1266

Check warning on line 308 in test/types/definitely-typed/instance.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Date.now()` over `Date#getTime()`. 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgzDzgvZm-J9EGdU&open=AZ4tGgzDzgvZm-J9EGdU&pullRequest=1266

Check warning on line 738 in test/types/definitely-typed/instance.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "httpCode". 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgzDzgvZm-J9EGdx&open=AZ4tGgzDzgvZm-J9EGdx&pullRequest=1266

Check failure on line 56 in test/types/internal-consumer.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of the "void" operator. 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgyVzgvZm-J9EGce&open=AZ4tGgyVzgvZm-J9EGce&pullRequest=1266

Check warning on line 830 in test/types/definitely-typed/manager.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Date.now()` over `Date#getTime()`. 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgyrzgvZm-J9EGdK&open=AZ4tGgyrzgvZm-J9EGdK&pullRequest=1266

Check warning on line 583 in test/types/definitely-typed/instance.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "httpCode". 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgzDzgvZm-J9EGdf&open=AZ4tGgzDzgvZm-J9EGdf&pullRequest=1266

Check warning on line 742 in test/types/definitely-typed/instance.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "aliasRequest". 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgzDzgvZm-J9EGdz&open=AZ4tGgzDzgvZm-J9EGdz&pullRequest=1266

Check warning on line 433 in test/types/definitely-typed/manager.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since the receiver accepts the original type of the expression. 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgyrzgvZm-J9EGcw&open=AZ4tGgyrzgvZm-J9EGcw&pullRequest=1266

Check failure on line 44 in test/types/internal-consumer.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of the "void" operator. 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgyVzgvZm-J9EGcb&open=AZ4tGgyVzgvZm-J9EGcb&pullRequest=1266

Check warning on line 734 in test/types/definitely-typed/instance.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Date.now()` over `Date#getTime()`. 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgzDzgvZm-J9EGdw&open=AZ4tGgzDzgvZm-J9EGdw&pullRequest=1266

Check failure on line 97 in test/types/public-consumer.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of the "void" operator. 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgzVzgvZm-J9EGeH&open=AZ4tGgzVzgvZm-J9EGeH&pullRequest=1266

Check warning on line 372 in test/types/definitely-typed/manager.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Date.now()` over `Date#getTime()`. 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgyrzgvZm-J9EGcq&open=AZ4tGgyrzgvZm-J9EGcq&pullRequest=1266

Check warning on line 739 in test/types/definitely-typed/manager.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "consentState". 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgyrzgvZm-J9EGdD&open=AZ4tGgyrzgvZm-J9EGdD&pullRequest=1266

Check warning on line 839 in test/types/definitely-typed/manager.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "aliasRequest". 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgyrzgvZm-J9EGdO&open=AZ4tGgyrzgvZm-J9EGdO&pullRequest=1266

Check warning on line 362 in test/types/definitely-typed/instance.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since the receiver accepts the original type of the expression. 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgzDzgvZm-J9EGdX&open=AZ4tGgzDzgvZm-J9EGdX&pullRequest=1266

Check warning on line 845 in test/types/definitely-typed/manager.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "consentState". 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgyrzgvZm-J9EGdP&open=AZ4tGgyrzgvZm-J9EGdP&pullRequest=1266

Check failure on line 76 in test/types/internal-consumer.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of the "void" operator. 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgyVzgvZm-J9EGcj&open=AZ4tGgyVzgvZm-J9EGcj&pullRequest=1266

Check warning on line 413 in test/types/definitely-typed/manager.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since the receiver accepts the original type of the expression. 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgyrzgvZm-J9EGcr&open=AZ4tGgyrzgvZm-J9EGcr&pullRequest=1266

Check warning on line 653 in test/types/definitely-typed/manager.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "aliasRequest". 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgyrzgvZm-J9EGc3&open=AZ4tGgyrzgvZm-J9EGc3&pullRequest=1266

Check warning on line 636 in test/types/definitely-typed/instance.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "aliasRequest". 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgzDzgvZm-J9EGdn&open=AZ4tGgzDzgvZm-J9EGdn&pullRequest=1266

Check warning on line 724 in test/types/definitely-typed/manager.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Date.now()` over `Date#getTime()`. 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgyrzgvZm-J9EGc-&open=AZ4tGgyrzgvZm-J9EGc-&pullRequest=1266

Check warning on line 119 in test/types/definitely-typed/instance.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "user". 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgzDzgvZm-J9EGdR&open=AZ4tGgzDzgvZm-J9EGdR&pullRequest=1266

Check failure on line 124 in test/types/public-consumer.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of the "void" operator. 

See more on https://sonarcloud.io/project/issues?id=mParticle_mparticle-web-sdk&issues=AZ4tGgzVzgvZm-J9EGeK&open=AZ4tGgzVzgvZm-J9EGeK&pullRequest=1266
View more details on SonarQubeCloud