fix(ci): stabilize BrowserStack Test workflow - #1321
Conversation
…SDK spec Firefox 51 on BrowserStack timed out because init's 400 identify was still in flight when the spec issued a second identify. Raise mocha timeout so several waitForCondition polls fit in one spec.
github.ref differs for those events, so the previous group still allowed two matrices for the same branch to contend for BrowserStack sessions.
PR SummaryLow Risk Overview Karma / BrowserStack: Duplicated config moves into Tests: Reviewed by Cursor Bugbot for commit 54cef9e. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit baf751e. Configure here.
The dotted browserstack.localIdentifier key is ignored by the launcher, so CI sessions were not pinned to the workflow tunnel.
rmi22186
left a comment
There was a problem hiding this comment.
Edge 15–18 marketshare is only .02%. let's just drop edge from our browserstack
Edge 15–18 is ~0.02% share. Keep Chromium Edge in the beta workflow.
|
Dropped |
Firefox 153 on Windows failed because the spec only waited on the default instance. Cap the beta workflow at 30 minutes and pin its tunnel.
|




Summary
Makes the BrowserStack Test workflow reliably green on
main. This is not caused by a recent product PR:masterrun 26452312354 (May 26) and PR run 31624825318 fail the same way.Failure modes in the logs:
src/changes — EdgeHTML workarounds were reverted after dropping the browser.transport error,has not captured in 60000 ms,Rate Limit Exceeded).Changes
test/cross-browser-testing/— removebs_edge_windows_15; share karma settings; pin sessions toBROWSERSTACK_LOCAL_IDENTIFIER; raise capture / no-activity / mocha timeouts..github/workflows/cross-browser-testing.yml—timeout-minutes: 30and a shared concurrency group for push + pull_request.test/src/config/utils.js— raisewaitForConditiondefault timeout for slow BrowserStack VMs.test/src/tests-core-sdk.js— wait for in-flight identify before retrying in the failed-config spec (Firefox 51).test/src/tests-mparticle-instance-manager.ts— wait for all instance cookies before asserting (Firefox 153 beta).Coverage tradeoff
Legacy EdgeHTML is no longer in the BrowserStack matrix (~0.02% share). Consent / cookie-sync coverage is not skipped on remaining browsers.
Test plan
npm run lintcleannpm run test:jest— 589/589