Skip to content

fix: hardcode xxh128 hash algorithm in product import#40687

Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz:fix/import-hardcode-xxh128
Open

fix: hardcode xxh128 hash algorithm in product import#40687
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz:fix/import-hardcode-xxh128

Conversation

@lbajsarowicz
Copy link
Copy Markdown
Contributor

@lbajsarowicz lbajsarowicz commented Apr 10, 2026

Description

Remove the PHP version check for hash algorithm selection in product import, hardcoding xxh128.

Problem

The product import constructor selects the hash algorithm with a version check:

$this->hashAlgorithm = (version_compare(PHP_VERSION, '8.1.0') >= 0) ? 'xxh128' : 'crc32c';

Since Magento requires PHP 8.3+, the xxh128 branch is always taken. The crc32c fallback is dead code.

Solution

Hardcode $this->hashAlgorithm = 'xxh128'; — the xxh128 algorithm has been available since PHP 8.1 and is faster than crc32c for hash table operations.

Files Changed

  • app/code/Magento/CatalogImportExport/Model/Import/Product.php

⭐ Support my work

Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.

Learn more at https://github.com/sponsors/lbajsarowicz

Resolved issues:

  1. resolves [Issue] fix: hardcode xxh128 hash algorithm in product import #40770: fix: hardcode xxh128 hash algorithm in product import

@m2-assistant
Copy link
Copy Markdown

m2-assistant Bot commented Apr 10, 2026

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Dash
Copy link
Copy Markdown
Contributor

@magento create issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P3 May be fixed according to the position in the backlog. Progress: pending review

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

[Issue] fix: hardcode xxh128 hash algorithm in product import

2 participants