Replace all gad_* parameters in VCL#40780
Open
sprankhub wants to merge 1 commit intomagento:2.4-developfrom
Open
Replace all gad_* parameters in VCL#40780sprankhub wants to merge 1 commit intomagento:2.4-developfrom
sprankhub wants to merge 1 commit intomagento:2.4-developfrom
Conversation
This makes sure that not only gad_source, but also gad_campaignid and all future gad tracking parameters are replaced. See https://support.google.com/google-ads/answer/16193746?hl=en
|
Hi @sprankhub. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Member
Author
|
@magento create issue |
5 tasks
Member
Author
|
Related: #40656 Sorry, saw it too late. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
This makes sure that not only
gad_source, but alsogad_campaignidand all futuregad_*tracking parameters are replaced. This way, the page will still be served by Varnish when a tracking parameter likegad_campaignidis used in the URL.See https://support.google.com/google-ads/answer/16193746?hl=en.
Related Pull Requests
n/a
Fixed Issues (if relevant)
Manual testing scenarios (*)
gad_campaignidlike https://www.shop.tld?gad_campaignid=abc.Questions or comments
Make sure to apply the VCL to your Varnish instance during your testing. It is not enough to just check out the code - you also need to apply the VCL during testing.
Contribution checklist (*)
Resolved issues: