Skip to content

Replace all gad_* parameters in VCL#40780

Open
sprankhub wants to merge 1 commit intomagento:2.4-developfrom
sprankhub:vcl-add-all-gad-params
Open

Replace all gad_* parameters in VCL#40780
sprankhub wants to merge 1 commit intomagento:2.4-developfrom
sprankhub:vcl-add-all-gad-params

Conversation

@sprankhub
Copy link
Copy Markdown
Member

@sprankhub sprankhub commented Apr 22, 2026

Description (*)

This makes sure that not only gad_source, but also gad_campaignid and all future gad_* tracking parameters are replaced. This way, the page will still be served by Varnish when a tracking parameter like gad_campaignid is used in the URL.

See https://support.google.com/google-ads/answer/16193746?hl=en.

Related Pull Requests

n/a

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. Make sure you use Varnish and have the full page cache enabled.
  2. Flush the cache.
  3. Open the homepage like https://www.shop.tld/. It should load "slow" as you just flushed the cache.
  4. Open the homepage like https://www.shop.tld/ again. It should load fast as it is now served through Varnish.
  5. Open the homepage with the gad_campaignid like https://www.shop.tld?gad_campaignid=abc.
  6. Without the changes to the VCL in this pull request, the homepage will load "slow" as it is not a cache hit. With this change, the homepage will load fast as it is a cache hit.

Questions or comments

Make sure to apply the VCL to your Varnish instance during your testing. It is not enough to just check out the code - you also need to apply the VCL during testing.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Replace all gad_* parameters in VCL #40781: Replace all gad_* parameters in VCL

This makes sure that not only gad_source, but also gad_campaignid and all future gad tracking parameters are replaced.

See https://support.google.com/google-ads/answer/16193746?hl=en
@m2-assistant
Copy link
Copy Markdown

m2-assistant Bot commented Apr 22, 2026

Hi @sprankhub. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@sprankhub
Copy link
Copy Markdown
Member Author

@magento create issue

@sprankhub
Copy link
Copy Markdown
Member Author

Related: #40656

Sorry, saw it too late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Issue] Replace all gad_* parameters in VCL

1 participant