Skip to content

Add integration tests for text-offset - #2002

Closed
kevinschaul wants to merge 1 commit into
maplibre:mainfrom
kevinschaul:1899/types-text-offset
Closed

Add integration tests for text-offset#2002
kevinschaul wants to merge 1 commit into
maplibre:mainfrom
kevinschaul:1899/types-text-offset

Conversation

@kevinschaul

Copy link
Copy Markdown
Contributor

Includes a test for the value of text-offset to be an expression. This test passes, which closes #1899.

These tests can be run with npm run test-style-spec.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.

Includes a test for the value of text-offset to be an expression. This
test passes, which closes maplibre#1899.
@github-actions

Copy link
Copy Markdown
Contributor

Bundle size report:

Size Change: 0 B
Total Size Before: 207 kB
Total Size After: 207 kB

Output file Before After Change
maplibre-gl.js 198 kB 198 kB 0 B
maplibre-gl.css 9.1 kB 9.1 kB 0 B
ℹ️ View Details No major changes

@HarelM

HarelM commented Dec 28, 2022

Copy link
Copy Markdown
Collaborator

Thanks for taking the time to contribute!!
I'm not sure I understand how this test closes #1898.
From what I understood in #1898 the input is valid but the type checking is incorrect.
This PR doesn't change the typings though...

@kevinschaul

Copy link
Copy Markdown
Contributor Author

My apologies, you are right. Closing this and will add more info to #1899.

@kevinschaul
kevinschaul deleted the 1899/types-text-offset branch December 28, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.1.9. -> 2.4.0 Expression types break interpolated text-offset

2 participants