Make tile group dimensions configurable per project type#252
Draft
frozenhelium wants to merge 2 commits into
Draft
Make tile group dimensions configurable per project type#252frozenhelium wants to merge 2 commits into
frozenhelium wants to merge 2 commits into
Conversation
a9ea86f to
2b425d2
Compare
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Collaborator
|
The tests are failing. We might need to go back and update the tests. We should be able to tweak the input parameters such that the output parameter is the same. |
tnagorra
reviewed
Jun 30, 2026
Comment on lines
+76
to
+77
| min_tile_x_multiplier: int = 2 | ||
| min_tile_y_multiplier: int = 3 |
Collaborator
There was a problem hiding this comment.
@frozenhelium if you have these numbers here, we can also re-use this number to calculate the no. of swipes.
Currently, find and completeness should have one swipe per 6 results.
tnagorra
reviewed
Jun 30, 2026
Comment on lines
+412
to
+413
| min_tile_x_multiplier: int = 2, | ||
| min_tile_y_multiplier: int = 3, |
Collaborator
There was a problem hiding this comment.
Let's not add defaults here. We already have default value in in the project classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
min_tile_x_multiplierandmin_tile_y_multiplierparametersTileMapServiceBaseProjectCompareProjectoverrides both to 1 so each group is a single tilemin_tile_x_multiplierandmin_tile_y_multiplierparameters toextent_to_groupsutility