Feat: set default pagination for public queries#266
Open
susilnem wants to merge 2 commits into
Open
Conversation
- update test cases for pagination test
susilnem
force-pushed
the
feature/high-pagination-size
branch
from
a739924 to
73d129b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #266 +/- ##
===========================================
+ Coverage 87.55% 87.64% +0.08%
===========================================
Files 211 212 +1
Lines 12819 12894 +75
Branches 1089 1093 +4
===========================================
+ Hits 11224 11301 +77
+ Misses 1196 1194 -2
Partials 399 399 ☔ View full report in Codecov by Harness. |
tnagorra
reviewed
Jun 30, 2026
Comment on lines
+33
to
+34
| if limit is UNSET or limit is None or limit < 0 or limit > max_limit: | ||
| pagination = OffsetPaginationInput(offset=pagination.offset, limit=max_limit) |
Collaborator
There was a problem hiding this comment.
This should throw an error, not silently serve max limit.
tnagorra
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR doesn't introduce any:
printThis PR contains valid: