Repository navigation
feat: add optional targetResolution to preview output - #4239
Open
ismaelsousa wants to merge 24 commits into
Open
ismaelsousa wants to merge 24 commits into
ismaelsousa wants to merge 24 commits into
Conversation
Store and forward outputOrientation to Preview.targetRotation so CameraX updates ResolutionInfo for the new target orientation. This keeps resolutionInfo.rotationDegrees synchronized instead of leaving it based on the default rotation.
Use AVCaptureDevice.RotationCoordinator on iOS 17 and later, creating the interface orientation manager only on older versions. Apply preview rotation updates synchronously and clean up observation on reconfiguration and deinit. Related PR: margelo#4237 Validation: VisionCamera iOS target build, Swift formatting, and git diff --check passed.
…nfiguration because does nothing anymore on android
|
@ismaelsousa is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
ismaelsousa
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4224
What
Adds an optional
targetResolutionto the Preview output, plus an optionalpreviewTargetResolutionprop on<Camera />.PreviewOutputOptions.targetResolution?: SizeusePreviewOutput({ targetResolution })(memoized by value viauseMemoizedSize, like the other output hooks)<Camera previewTargetResolution={...} />Previewgets aResolutionSelectorthat sorts sizes by closest to the targettargetResolutionreturns.closestTo(...)when set, otherwise the existing screen-size bias is unchangedWhen omitted, behavior is unchanged on both platforms.
Why
Every output is a view of the same sensor, and outputs with different aspect ratios crop it differently. The Preview can then show more (or less) than a Frame/Photo/Video output actually sees.
This is mainly an Android problem. CameraX picks a default aspect ratio per use case: image capture/analysis default to 4:3, video usually resolves to 16:9, and the Preview defaults to 4:3. A 16:9 video next to a 4:3 Preview covers a different area than what the user sees, and Android ignores
resolutionBias, so the Preview could not be steered before.Setting the Preview's
targetResolutionto match another output (e.g. the video output) aligns their field of view.On iOS every output derives from the resolved active format, so
targetResolutionshould not be specified there; use aresolutionBiasconstraint to steer the resolution instead. This is documented.Docs
Rewrote the "Preview Resolution" section in
preview-output.mdx(the old text said the Preview has no configurable target resolution) and documented the option in JSDoc.Notes
targetResolutionis a preference negotiated with the session's other outputs, so the resulting resolution may differ; useonConfigurationChanged/onPreviewResolutionto read the actual size.Example
Android (Samsung SM-A556E). The example draws the four corners of the frame output (always
HD_16_9) as red dots on the preview. If the preview and the frame cover the same area, the dots sit on the preview's corners.targetResolutionmismatchedtargetResolutionmatchedFHD_4_3(1080 × 1440) with aHD_16_9frame: the 4:3 preview shows more than the frame, so the dots are inset.HD_16_9(720 × 1280): the dots sit exactly on the preview corners.