Update Locale to handle synchronous JSON file loading, when possible.#1481
Open
dpvc wants to merge 1 commit into
Open
Update Locale to handle synchronous JSON file loading, when possible.#1481dpvc wants to merge 1 commit into
dpvc wants to merge 1 commit into
Conversation
Member
Author
|
I've added the |
Member
Author
|
I will need to change this PR in light of our meeting today. So wait with it for now. |
dpvc
force-pushed
the
feature/locale-sync
branch
2 times, most recently
from
f350e8e to
227d6cb
Compare
Member
Author
|
OK, Ive reverted this branch to the original purpose of adding the synchronous loading of locale files, when possible. I will do the other changes in a separate PR, so this one can be reviewed at this point. |
dpvc
force-pushed
the
feature/locale-sync
branch
2 times, most recently
from
22ff232 to
7f32b1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the
Localeobject to load the localization files synchronously, when themathjax.asyncLoadmethod is marked as synchronous. It also fixes the JSDoc issue that I mentioned in the review of #1479.