Add localization for loader and startup via core/__locales__#1485
Open
dpvc wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR adds localization to the
loaderandstartupmodules. It does so by adding acore/__locales__directory for thecorecomponent, and using that for their messages, since theloaderandstartupcomponents include thecorecomponent. These components now loadcore/locale.jsbeforelib/loader.jsorlib/startup.jsso that theLocale.isComponentvalue is set before the files imported by thelibcode (in particular, theirComponent.jsfiles) are loaded. OtherwiseLocalemight use the wrong directory when trying to find the localization files.Copying the
corelocalization has been added to the package scripts, and I've also taken this opportunity to adjust thecopy:assetsandcopy:localesscripts to use a list of sub-scripts to run rather than having them explicitly called. This allows new ones to be added easier, and also to makemjsthe default for$1so you can just usepnpm -s copy:assetswithout needing to specifymjsdirectly.The rest is just the changes to localize the messages in
loader.tsandstartup.ts.