Skip to content

[feat] Stale old alerts on line diagram banner #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lvachon1 wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

[feat] Stale old alerts on line diagram banner #3281

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2e9f28a
Added filter to remove alerts older than five weeks from the line dia…
lvachon1 Jun 23, 2026
db38f58
Moved stale calculation to inside the alert module
lvachon1 Jun 26, 2026
a5722f5
Updated logic to determine which active_period is current
lvachon1 Jun 26, 2026
2b19d41
Converted test date format to DateTime instead of NaiveDateTime
lvachon1 Jun 26, 2026
236732e
I disagree with the robot that this is too complex
lvachon1 Jun 29, 2026
1f1086a
Whoops, revered the logic here
lvachon1 Jun 29, 2026
872026a
Maybe it is too complex... reverted inversion of logic.
lvachon1 Jun 29, 2026
ba7b068
Added tests, committed these to the wrong (but related) branch.
lvachon1 Jun 29, 2026
cfe334e
I have code that allows for a nil start date earlier in the chain, mi…
lvachon1 Jun 30, 2026
a0aa65a
Lint
lvachon1 Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/dotcom_web/templates/schedule/_line.html.heex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,11 @@

<div class="page-section m-schedule-line">
{DotcomWeb.AlertView.group(
alerts: @alerts,
alerts:
@alerts
|> Enum.filter(fn %{created_at: created_at} ->
Comment thread
lvachon1 marked this conversation as resolved.
Outdated
DateTime.after?(created_at, DateTime.add(@date_time, -5 * 7, :day))
end),
Comment thread
lvachon1 marked this conversation as resolved.
Outdated
route: @route,
date_time: @date_time,
priority_filter: :high
Expand Down
Loading