Review of McStasToX: https://github.com/mccode-dev/McStasToX
This is an early version of the package, still without documentation, testing and CI. The main purpose of this review is to ensure the package has a healthy structure so that it can be:
- Easily expanded to more functionality (writing nexus files, exporting to other formats, read more geometries)
- Easily maintained
It is foreseen that the code surrounding the package for documentation, CI and so forth will follow the scipp template which can be applied retroactively. This is partly to ensure easy collaboration with the scipp team.
The module is currently two files, so it is natural to split the review in two as well:
- NeXus reading in ReadNeXus
- Interface and transformation in LoadFile
The demo notebooks show examples of how to use the code.
Review of McStasToX: https://github.com/mccode-dev/McStasToX
This is an early version of the package, still without documentation, testing and CI. The main purpose of this review is to ensure the package has a healthy structure so that it can be:
It is foreseen that the code surrounding the package for documentation, CI and so forth will follow the scipp template which can be applied retroactively. This is partly to ensure easy collaboration with the scipp team.
The module is currently two files, so it is natural to split the review in two as well:
The demo notebooks show examples of how to use the code.