Repository navigation
Popover API examples: add accessibility notes to README - #402
Merged
chrisdavidmills merged 2 commits intoOct 12, 2026
Merged
Conversation
chrisdavidmills
approved these changes
Oct 12, 2026
chrisdavidmills
left a comment
chrisdavidmills
left a comment
Contributor
There was a problem hiding this comment.
I guess this is better for now, although eventually we should make these demos more accessible. Thanks, @ump45nose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an "Accessibility notes" section to
popover-api/README.mdsaying that the demos are not complete accessible components: the blur-background demo is still a non-modal popover (the page behind is not inert), the nested popover menu is nested lists of links rather than an ARIAmenu, and the toast demo has no live region. It points to "Popover accessibility features" on MDN.Motivation
mdn/content#35811 reports that these demos look like a modal dialog and a menu without the accessibility work those patterns need. The demos are in this repo, so the note goes here, not in mdn/content.
Additional details
Validation boundary: I checked the demo source in this repo (no
aria-*/roleattributes inblur-background,nested-popoversortoast-popovers) and that the linked MDN pages and the#popover_accessibility_featuresanchor exist. I did not test with a screen reader, and I did not change the demos themselves. Reworking the demos (e.g. making the nested example open submenus on demand, as the issue suggests) would be a separate change.Related issues and pull requests
Relates to mdn/content#35811
AI assistance disclosure: this change was prepared with the help of an AI coding agent (Grok Bot) and has not been reviewed line by line by the account owner.