Skip to content

fix(compat-table): simplify compat-support-flags fluent string #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nmleuz wants to merge 5 commits into
base: main
Choose a base branch
from
+44 −57
Open

fix(compat-table): simplify compat-support-flags fluent string #1738

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
177ebce
fix(compat-table): simplify compat-support-flags fluent string
nmleuz Jul 24, 2026
0f0f72a
Merge branch 'main' into fix/compat-support-flags-fluent-string
nmleuz Jul 29, 2026
265f115
Change message id to invalidate older version in other locales
nmleuz Jul 29, 2026
72ff744
Merge branch 'main' into fix/compat-support-flags-fluent-string
nmleuz Jul 30, 2026
4e8b4b7
Move block out of for loop and fix indents
nmleuz Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions components/compat-table/element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,18 +738,27 @@ export class MDNCompatTable extends L10nMixin(LitElement) {

if (item.flags) {
for (const { type, name, value_to_set } of item.flags) {
const hasAdded =
typeof item.version_added === "string" &&
item.version_added !== "preview";
const hasLast = typeof item.version_last === "string";

const versionRange = hasAdded
? hasLast
? "range"
: "from"
: hasLast
? "until"
: "none";
Comment thread
nmleuz marked this conversation as resolved.
Outdated

supportNotes.push({
iconName: "disabled",
label: this.l10n.raw({
id: "compat-support-flags",
args: {
has_added: Number(
typeof item.version_added === "string" &&
item.version_added !== "preview",
),
version_range: versionRange,
Comment thread
LeoMcA marked this conversation as resolved.
version_added: item.version_added,
has_last: Number(typeof item.version_last === "string"),
versionLast: item.version_last,
version_last: item.version_last,
flag_type: type,
flag_name: name,
has_value: Number(typeof value_to_set === "string"),
Expand Down
34 changes: 12 additions & 22 deletions l10n/locales/en-US.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,33 +92,23 @@ compat-branch-prefix-altname = Prefix: <code data-l10n-name="prefix">{ $prefix }
compat-support-removed = Removed in { $version } and later
compat-support-see-impl-url = See <a data-l10n-name="impl_url">{ $label }</a>
compat-support-flags =
{ $has_added ->
[1] From version { $version_added }
*[0] {""}
}{ $has_last ->
[1] { $has_added ->
*[0] Until { $versionLast } users
[1] {" "}until { $versionLast } users
}
*[0] { $has_added ->
*[0] Users
[1] {" "}users
}
}
{" "}must explicitly set the <code data-l10n-name="name">{ $flag_name }</code>{" "}
{ $flag_type ->
{ $version_range ->
[range] From version { $version_added } until { $version_last }, users
[from] From version { $version_added }, users
[until] Until { $version_last }, users
*[none] Users
} must explicitly set the <code data-l10n-name="name">{ $flag_name }</code> { $flag_type ->
*[preference] preference
[runtime_flag] runtime flag
}{ $has_value ->
[1] {" "}to <code data-l10n-name="value">{ $flag_value }</code>
*[0] {""}
}{"."}
{ $has_pref_url ->
[1]{ " " }to <code data-l10n-name="value">{ $flag_value }</code>
*[0] { "" }
}.{ $has_pref_url ->
[1] { $flag_type ->
[preference] To change preferences in { $browser_name }, visit { $browser_pref_url }.
*[other] {""}
[preference]{ " " }To change preferences in { $browser_name }, visit { $browser_pref_url }.
*[other] { "" }
}
*[0] {""}
*[0] { "" }
}

compat-legend = Legend
Expand Down
28 changes: 8 additions & 20 deletions l10n/template.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,33 +57,21 @@ compat-branch-prefix-altname = Prefix: <code data-l10n-name="prefix">{ $prefix }
compat-support-removed = Removed in { $version } and later
compat-support-see-impl-url = See <a data-l10n-name="impl_url">{ $label }</a>
compat-support-flags =
{ $has_added ->
[1] From version { $version_added }
*[0] { "" }
}{ $has_last ->
[1]
{ $has_added ->
*[0] Until { $versionLast } users
[1] { " " }until { $versionLast } users
}
*[0]
{ $has_added ->
*[0] Users
[1] { " " }users
}
}
{ " " }must explicitly set the <code data-l10n-name="name">{ $flag_name }</code>{ " " }
{ $flag_type ->
{ $version_range ->
[range] From version { $version_added } until { $version_last }, users
[from] From version { $version_added }, users
[until] Until { $version_last }, users
*[none] Users
} must explicitly set the <code data-l10n-name="name">{ $flag_name }</code> { $flag_type ->
*[preference] preference
[runtime_flag] runtime flag
}{ $has_value ->
[1] { " " }to <code data-l10n-name="value">{ $flag_value }</code>
*[0] { "" }
}{ "." }
{ $has_pref_url ->
}.{ $has_pref_url ->
[1]
{ $flag_type ->
[preference] To change preferences in { $browser_name }, visit { $browser_pref_url }.
[preference] { " " }To change preferences in { $browser_name }, visit { $browser_pref_url }.
*[other] { "" }
}
*[0] { "" }
Expand Down
Loading