Resolves resampling issues due to timezone differences.#467
Open
sohamsjain wants to merge 2 commits intomementum:masterfrom
Open
Resolves resampling issues due to timezone differences.#467sohamsjain wants to merge 2 commits intomementum:masterfrom
sohamsjain wants to merge 2 commits intomementum:masterfrom
Conversation
Datafeed sourced from IB API receives timezone info from contractdetails. This tz info was not passed to num2date() method in lines 275 and 276. This results in an offset in the point value returned by self._gettmpoint(tm). This offset distorts the resampling and produces bars at irregular intervals. Above modifications takes care of the same. Note: Modified code was tested on `Minute 1` timeframe resampled to 20, 25 & 75 minutes using ibdata and data form local csv file.
|
@sohamsjain This is the most recent PR of this repo so I thought to reach out. I would like to contribute to the repo but there is multiple repos and I'm not sure what is maintained. So which of those are active, the community has links to herbal remedies, yoga, and quickbooks spam, there seems to be no central 'we are doing this' place?
|
|
@datatalking Unfortunately, even backtrader2 doesn't look like it's actively maintained. So far, I have found 2 forks that seem to be actively maintained: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Datafeed sourced from IB API receives timezone info from contractdetails.
This tz info was not passed to num2date() method in lines 275 and 276.
This results in an offset in the point value returned by self._gettmpoint(tm).
This offset distorts the resampling and produces bars at irregular intervals.
Above modifications takes care of the same.
Note: Modified code was tested on
Minute 1timeframe resampled to 20, 25 & 75 minutes using ibdata and data form local csv file.