Repository navigation
[MOO-2490] : Update Video player and remove unused trackplayer package + patch - Master - #1357
Open
saurabhchavan1711 wants to merge 2 commits into
Open
saurabhchavan1711 wants to merge 2 commits into
saurabhchavan1711 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Video Player's exoplayer and track player's exoplayer are conflicting with eachothers . As of now the video players exoplayer took precedence so the Video player widget is not crashing but due to vision camera v5 migration , the track players exoplayer is taking the precedence thus Video player was crashing at runtime. To fix this I have removed the unused trackplayer library and its patch as it was not required at all (we are using react native sound instead & the track player patch and library declaration in package.json is stale code).
Checklist
To ensure this pull request meets the requirements for merging, please complete the checklist below:
This PR contains