Fix i3lock-fancy script for ImageMagick 7+ compatibility#200
Open
megvadulthangya wants to merge 1 commit intomeskarune:masterfrom
Open
Fix i3lock-fancy script for ImageMagick 7+ compatibility#200megvadulthangya wants to merge 1 commit intomeskarune:masterfrom
megvadulthangya wants to merge 1 commit intomeskarune:masterfrom
Conversation
compatibility with ImageMagick 7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
i3lock-fancyscript to replace all instances ofconvertwithmagickfor compatibility with ImageMagick 7+. In ImageMagick 7+, the traditional command-line tools (e.g.,convert,mogrify) are prefixed withmagickto avoid naming conflicts.Changes Made
convertwithmagickin/usr/bin/i3lock-fancy.Why This Change?
ImageMagick 7+ requires the use of the
magickprefix for its command-line tools. Without this change, the script fails with a "command not found" error on systems using newer versions of ImageMagick.Testing
Additional Notes
magickis included with ImageMagick 7+.