fix(cargo): skip execroot symlink collisions in build script runner - #1
Open
erikackermann wants to merge 2 commits into
Open
fix(cargo): skip execroot symlink collisions in build script runner#1erikackermann wants to merge 2 commits into
erikackermann wants to merge 2 commits into
Conversation
When experimental_symlink_execroot is enabled, only track symlinks the runner created and remove symlinks on cleanup. Avoids failing with "Is a directory" when an execroot path collides with an existing manifest dir entry (e.g. monorepo ci/ vs crate runfiles).
Fix buildifier-lint unsorted-dict-items on urls.bzl so pre-commit passes.
Owner
Thanks @erikackermann! Would you be able to add a test case that demonstrates this weird behavior? That will be very useful for an upstream PR as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
experimental_symlink_execrootis enabled.symlink_metadata), not real directories.Fixes intermittent failures where execroot paths (e.g. top-level
ci/) collide with crate runfile trees and cleanup failed withIs a directory.