Upgrade to current Bootstrap - brings small design changes#22
Conversation
Co-Authored-By: Brian Tremblay <dev@btrem.com>
|
Does a one page website need bootstrap at all? |
|
The Bootstrap dependency, in my opinion, is there so all parser pages can use the same design. Regardless of who ends up writing them. It also means people do not need to go out and decide their own styling for elements. E.g. this page does not use checkboxes and I might have not included them in the CSS. But the PHP parser does need them. By already having decided on Bootstrap, a decision made years ago, we can skip a lot of bikeshedding on the design and just use the defaults. Edit: of course this one does use checkboxes, there are other pages that do not. Like the Go one that I was recently looking at updating too… I think the point is still the same. |
Ok. But why do all the parser pages need to use the same design? Hey, it's your repo (or at least it's not mine). So do what you want. But ISTM that it isn't necessary. FWIW, the only difference I see in the two screenshots you provided is the select element, which now extends across the screen. I hate that (I got stuck with the same thing on a Drupal site I manage, after changing the theme). But that's a personal preference. |
|
The width of that select can be changed pretty easily with the BS5 grid classes: https://getbootstrap.com/docs/5.3/forms/layout/#form-grid |
Currently the template uses an old alpha version of Bootstrap 4. It does not make sense to be using an alpha version at all. Bootstrap 5 had its first release 2021-05-05, maybe it is time to make the step 5+ years later. This PR does a few things:
<section>does not make sense.titleattribute and into an associate visible text instead.As an aside I have also tweaked some inaccuracies in the README that were just never updated, like the move from the indieweb org to the microformats org. Happy to split that commit into a separate PR if it turns out this PR stalls.
Comparison