Update backup.tf#4973
Merged
Merged
Conversation
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 55c95e0. ♻️ This comment has been updated with latest results. |
maxmartin-cgi
approved these changes
Jul 15, 2026
Collaborator
Author
|
@copilot update changelog and bump template version number |
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure TRE base workspace template to stop explicitly disabling Recovery Services Vault soft delete, aligning with current Azure behavior (soft delete enabled by default and not allowed to be disabled), and preventing workspace creation failures like the one reported in #4967.
Changes:
- Removed
soft_delete_enabled = falsefrom the base workspaceazurerm_recovery_services_vaultdefinition. - Bumped the base workspace template version from 2.8.3 → 2.8.4.
- Added a corresponding BUG FIXES entry to
CHANGELOG.mdreferencing #4967.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| templates/workspaces/base/terraform/backup/backup.tf | Removes the explicit soft delete disable setting to avoid Azure API failures. |
| templates/workspaces/base/porter.yaml | Bumps the base workspace bundle version to reflect the template change. |
| CHANGELOG.md | Documents the fix under Unreleased BUG FIXES with a link to #4967. |
marrobi
approved these changes
Jul 15, 2026
Collaborator
Author
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 55c95e0) (in response to this comment from @rudolphjacksonm) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4967
What is being addressed
Updated base template to remove
soft_delete = enabledfrom theazurerm_recovery_services_vaultresource as this is no longer a setting which can be configured and is enabled by default on resource creation.How is this addressed
soft_delete_enabledproperty from theazurerm_recovery_services_vaultresource intemplates/workspaces/base/terraform/backup/backup.tfCHANGELOG.mdwith a BUG FIXES entry referencing #49672.8.3to2.8.4inporter.yaml