Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Kafka 0.9 producer fix #22

Open
John Stark (johnstark) wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Kafka 0.9 producer fix #22

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04566da
Fix for 0.9 producer
johnstark Mar 7, 2016
f92952d
comment with explanation
johnstark Mar 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/KafkaNET.Library/Cfg/SyncProducerConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public class SyncProducerConfiguration : ISyncProducerConfigShared

public const int DefaultCorrelationId = -1;

public const string DefaultClientId = "";
public const string DefaultClientId = " ";

@soumyajit-sahu Soumyajit Sahu (soumyajit-sahu) Apr 29, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

John Stark (@johnstark) , Can we set it to something less obscure?
Java api does something like following which could help while debugging.

if (clientId.length() <= 0)
clientId = "producer-" + PRODUCER_CLIENT_ID_SEQUENCE.getAndIncrement();


public const short DefaultRequiredAcks = 0;

Expand Down