Skip to content

[SECURITY] Fix CodeQL SM02196: suppress weak-hash warnings in negative test #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elantiguamsft merged 1 commit into from
Jun 22, 2026
Merged

[SECURITY] Fix CodeQL SM02196: suppress weak-hash warnings in negative test #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CoseIndirectSignature.Tests/CoseHashEnvelopeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public void SignatureMatchesRejectsLegacyDigestAlgorithms(string hashSuffix)
CoseSign1MessageFactory factory = new();
byte[] payload = Encoding.UTF8.GetBytes("payload-to-verify");

using HashAlgorithm legacyHasher = hashSuffix == "md5" ? MD5.Create() : SHA1.Create();
using HashAlgorithm legacyHasher = hashSuffix == "md5" ? MD5.Create() : SHA1.Create(); // CodeQL [SM02196] Negative test: MD5/SHA1 are intentional inputs verifying the library rejects legacy digest algorithms.
byte[] payloadHash = legacyHasher.ComputeHash(payload);

CoseSign1Message message = factory.CreateCoseSign1Message(
Expand Down
Loading