Update release notes for 1.9.2609 - #8914
Conversation
Add missing stable and Shader Model 6.10 preview changes since the 1.9.2607 branch point. Consolidate the duplicate Bug Fixes sections. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f12a72d2-e956-4ca9-a301-5caca8d1b353
Leave the work graph release note in its original location and formatting so the release notes update contains only intentional additions and section cleanup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f12a72d2-e956-4ca9-a301-5caca8d1b353
Remove the itemized LinAlg additions so the feature owner can add the intended release-level summary when it is ready. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f12a72d2-e956-4ca9-a301-5caca8d1b353
There was a problem hiding this comment.
🟡 Changes recommended
Several entries are inaccurate or link pull requests contrary to the documented release-note policy.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the upcoming 1.9.2609 release notes with omitted fixes and SPIR-V changes.
Changes:
- Adds missing compiler and SPIR-V entries.
- Removes an accidental duplicate bug-fix section.
- Corrects punctuation and section placement.
File summaries
| File | Description |
|---|---|
docs/ReleaseNotes.md |
Updates and reorganizes upcoming release entries. |
Review details
Suppressed comments (1)
docs/ReleaseNotes.md:70
CONTRIBUTING.md:139says release-note entries should not link to specific pull requests. The implementing PR identifies bug #7740, so this can link that issue instead.
- `globallycoherent` is now supported on `ResourceDescriptorHeap` accesses
[#8513](https://github.com/microsoft/DirectXShaderCompiler/pull/8513).
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Describe the template-specialization assertion accurately and replace implementation PR links with the related bug where available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f12a72d2-e956-4ca9-a301-5caca8d1b353
| - Inline `[[vk::ext_decorate]]`, `[[vk::ext_capability]]`, and | ||
| `[[vk::ext_extension]]` attributes are now honored on ordinary functions. |
There was a problem hiding this comment.
Missing issue/PR link?
There was a problem hiding this comment.
The review bot was instructed to not allow PR links and instead link issues. So, it commented on this, but this PR doesn't seem to have an associated issue.
I'll add the PR reference back in. The bot is going to comment but it's not blocking. This will be something to follow up with in its policy for the future.
Use the implementing PR for traceability because no issue accurately covers this change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f12a72d2-e956-4ca9-a301-5caca8d1b353
There was a problem hiding this comment.
🔵 Needs a closer look
A new entry violates the repository policy against linking directly to pull requests.
Review details
Suppressed comments (1)
docs/ReleaseNotes.md:68
CONTRIBUTING.md:136-140says release-note entries should not link to specific pull requests. This new entry links directly to PR #8616; please remove that link (or replace it with a relevant bug link, if one exists).
[#8616](https://github.com/microsoft/DirectXShaderCompiler/pull/8616).
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Balanced
Update some missing release notes and remove an accidental extra bug fix section.