Upgrade Windows Telegraf to 1.40.0 - #1785
Draft
zanejohnson-azure wants to merge 1 commit into
Draft
zanejohnson-azure wants to merge 1 commit into
zanejohnson-azure wants to merge 1 commit into
Conversation
Consume the official upstream Windows package with a pinned SHA256 and migrate timeout, field-filter, and procstat PID-tag configuration. Preserve ConfigMap keys and Linux behavior; document the deferred discovery cleanup and deadline gaps. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
| Move-Item -Path /installation/telegraf/*/* -Destination /opt/telegraf/ -ErrorAction SilentlyContinue | ||
| # Update the Windows Telegraf configs and tomlparser-prom-customconfig.rb together with this package. | ||
| $telegrafUri='https://dl.influxdata.com/telegraf/releases/telegraf-1.40.0_windows_amd64.zip' | ||
| $telegrafSha256='9d85e3fa89d99e4b0e53e4aa40f069e828204cf5548ede9b9b7c95c31fe869dd' |
| Dir.mktmpdir("windows-telegraf-config") do |dir| | ||
| path = File.join(dir, "telegraf.conf") | ||
| File.write(path, conf) | ||
| Open3.popen3({ "NODE_IP" => "127.0.0.1" }, binary, "--console", "--test", "--config", path) do |stdin, stdout, stderr, process| |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade the official upstream-built Windows AMD64 Telegraf package from 1.24.2 to 1.40.0. This consumes upstream's node-discovery token-file reload on retries after a failed poll, allowing discovery to recover after token rotation without relying on file modification time or restarting Telegraf.
timeoutrather than the newer response-header-onlyresponse_timeout.fieldinclude/fieldexclude, while keeping public ConfigMapfieldpass/fielddropkeys and Linux rendering unchanged.pid_tagtotag_with = ["pid"], preserving process selection, CPU/RSS fields, and telemetry tags.Package provenance
e9017dc3266369d6fa185e0e130af1d1d4021ce9, withvcs.modified=falsein the downloaded executable.9d85e3fa89d99e4b0e53e4aa40f069e828204cf5548ede9b9b7c95c31fe869dd.windows/amd64,GOAMD64=v1. LTSC2019 and LTSC2022 meet Go's documented Windows OS floor; this does not substitute for image validation.Scope and remaining limitations
This is a stock-package upgrade / partial mitigation, not a Telegraf source patch, backport, or source-build workflow. The upstream non-200 response-body cleanup defect and unbounded cAdvisor discovery requests remain unfixed. The metric-scrape timeout does not bound discovery. No HTTP/2, kubelet, TLS, or authentication workarounds are introduced.
Independent of #1782:
kubernetes/windows/main.ps1and the WS2025 startup behavior are unchanged. Based onci_prodcommit8e6bef5637c8d0e1e52299cfb2bd9ecb3645a8ca.Completed validation
--console --test: migrated configuration loads and emits CPU/RSS metrics with PID tags; output plugins are not run.The rotation fixture used a synthetic kubeconfig
tokenFile, not a real projected mount, in-cluster credential configuration, installed Windows service, or deployed image.Remaining validation
No image build, deployment, live-cluster change, or SCM service installation/restart was performed as part of this change.