fix: factor execution env crashes when no conda environment is active - #1462
Open
chrisbatso wants to merge 1 commit into
Open
fix: factor execution env crashes when no conda environment is active#1462chrisbatso wants to merge 1 commit into
chrisbatso wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
get_factor_env()inrdagent/components/coder/factor_coder/config.pyunconditionally builds a conda-based environment:hasattr(conf, "python_bin")is alwaysTrue(python_binis a declared settings field with a default), so on any host where the process is not running inside an activated conda environment,CONDA_DEFAULT_ENVis unset andCondaConfraises:This makes
rdagent fin_factorcrash at loop 0 on any conda-less installation (e.g. a plain venv/uv setup on a fresh Ubuntu server), even though nothing about factor execution actually requires conda.Fix
Keep the conda path when
CONDA_DEFAULT_ENVis set; otherwise fall back to aLocalEnvwhosebin_pathis the current interpreter's own bin directory, so factor code runs with the environment RD-Agent itself was installed into.Testing
Reproduced on Ubuntu 26.04 with RD-Agent installed in a uv-managed venv (no conda present):
rdagent fin_factorcrashed with the ValidationError above; with this patch, factor implementation, execution, and full qlib R&D loops (15 loops, multiple LLM backends) run to completion. The conda path is unchanged for users inside an activated env.馃 Generated with Claude Code
馃摎 Documentation preview 馃摎: https://RDAgent--1462.org.readthedocs.build/en/1462/