fix: preserve stdout between EDA blocks - #1465
Open
Jimmy Wang (JimmyWang0417) wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Match each EDA block independently so normal stdout between multiple blocks is preserved.
Motivation and Context
The previous greedy match removed text from the first start marker through the last end marker when stdout contained multiple EDA blocks.
Fixes #1459.
How Has This Been Tested?
python -m pytest test/utils/coder/test_data_science_utils.py -qpython -m compileall -q rdagent/components/coder/data_science/utils.py test/utils/coder/test_data_science_utils.pygit diff --checkThe focused regression test passes. The full test suite was not run.
Types of changes
馃摎 Documentation preview 馃摎: https://RDAgent--1465.org.readthedocs.build/en/1465/