fix: handle missing queried knowledge in model strategy - #1472
Open
s4kura (Iams4kura) wants to merge 1 commit into
Open
fix: handle missing queried knowledge in model strategy#1472s4kura (Iams4kura) wants to merge 1 commit into
s4kura (Iams4kura) wants to merge 1 commit into
Conversation
|
s4kura (@Iams4kura) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use the queried-knowledge layer's shape-compatible
([], None)empty value whenqueried_knowledgeis omitted fromModelMultiProcessEvolvingStrategy.implement_one_task.This also adds an offline regression test that exercises the direct strategy call without making model or network requests.
Motivation and Context
Fixes #1461.
The method declares
queried_knowledgeas optional, but itsNonebranch previously returned an empty list and then immediately indexed it as a two-item failed-knowledge tuple. Direct callers therefore received an incidentalIndexErrorbefore prompt construction or backend invocation.How Has This Been Tested?
If you are adding a new feature, test on your own test scripts.
python -m pytest -p no:cacheprovider -q test/scenarios/data_science/test_model_strategy_none_knowledge.py(1 passed)make test-offline(3 tests and 299 subtests passed)make lintmake docs-genmake buildScreenshots of Test Results (if appropriate):
Not applicable; this is a deterministic unit-level regression.
Types of changes
📚 Documentation preview 📚: https://RDAgent--1472.org.readthedocs.build/en/1472/