Skip to content

fix: report error for private property access on generic intersection types #63548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hesam-oxe wants to merge 3 commits into from
Closed

fix: report error for private property access on generic intersection types #63548

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7028cd
fix: report error for private property access on generic intersection…
hesam-oxe Jun 11, 2026
a5c74e8
Merge branch 'main' into fix/private-intersection-error
hesam-oxe Jun 11, 2026
4013aae
fix: handle missing accessNode and null declaringClass
hesam-oxe Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19656,6 +19656,17 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
return wildcardType;
}
objectType = getReducedType(objectType);
// If the object type is an intersection with conflicting private properties,
// report an error — we shouldn't be able to access those properties via T["key"]
if (objectType.flags & TypeFlags.Intersection && !(objectType.flags & TypeFlags.Never)) {
const props = getPropertiesOfUnionOrIntersectionType(objectType as IntersectionType);
const conflictingPrivate = find(props, isConflictingPrivateProperty);
if (conflictingPrivate && accessNode) {
error(accessNode, Diagnostics.Property_0_is_private_and_only_accessible_within_class_1,
symbolToString(conflictingPrivate), typeToString(getDeclaringClass(conflictingPrivate)!));
return undefined;
}
}
// If the object type has a string index signature and no other members we know that the result will
// always be the type of that index signature and we can simplify accordingly.
if (isStringIndexSignatureOnlyType(objectType) && !(indexType.flags & TypeFlags.Nullable) && isTypeAssignableToKind(indexType, TypeFlags.String | TypeFlags.Number)) {
Expand Down