Skip to content

Fix mutable default list argument in config classes #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hobostay wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix mutable default list argument in config classes #384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions vibevoice/modular/configuration_vibevoice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,22 +52,24 @@ def __init__(
weight_init_value: float = 1e-2,
# encoder specific
encoder_n_filters: int = 32,
encoder_ratios: Optional[List[int]] = [8,5,5,4,2,2],
encoder_ratios: Optional[List[int]] = None,
encoder_depths: str = "3-3-3-3-3-3-8",
# decoder specific
decoder_n_filters: int = 32,
decoder_ratios: Optional[List[int]] = None, # if None, same as encoder
decoder_ratios: Optional[List[int]] = None,
decoder_depths: Optional[str] = None,
**kwargs
):
super().__init__(**kwargs)
if encoder_ratios is None:
encoder_ratios = [8, 5, 5, 4, 2, 2]
self.channels = channels
self.corpus_normalize = corpus_normalize
self.causal = causal
self.vae_dim = vae_dim
self.fix_std = fix_std
self.std_dist_type = std_dist_type

# common parameters
self.conv_norm = conv_norm
self.pad_mode = pad_mode
Expand All @@ -84,16 +86,16 @@ def __init__(
self.encoder_n_filters = encoder_n_filters
self.encoder_ratios = encoder_ratios
self.encoder_depths = encoder_depths

# decoder specific parameters
self.decoder_ratios = decoder_ratios if decoder_ratios is not None else encoder_ratios
self.decoder_ratios = decoder_ratios if decoder_ratios is not None else list(encoder_ratios)
self.decoder_n_filters = decoder_n_filters
self.decoder_depths = decoder_depths


class VibeVoiceSemanticTokenizerConfig(PretrainedConfig):
model_type = "vibevoice_semantic_tokenizer"

def __init__(
self,
channels: int = 1,
Expand All @@ -102,7 +104,7 @@ def __init__(
vae_dim: int = 64,
fix_std: float = 0,
std_dist_type: str = 'none',
# common
# common
mixer_layer: str = 'depthwise_conv',
conv_norm: str = 'none',
pad_mode: str = 'constant',
Expand All @@ -115,18 +117,20 @@ def __init__(
weight_init_value: float = 1e-2,
# encoder specific
encoder_n_filters: int = 32,
encoder_ratios: Optional[List[int]] = [8,5,5,4,2,2],
encoder_ratios: Optional[List[int]] = None,
encoder_depths: str = "3-3-3-3-3-3-8",
**kwargs
):
super().__init__(**kwargs)
if encoder_ratios is None:
encoder_ratios = [8, 5, 5, 4, 2, 2]
self.channels = channels
self.corpus_normalize = corpus_normalize
self.causal = causal
self.vae_dim = vae_dim
self.fix_std = fix_std
self.std_dist_type = std_dist_type

# common parameters
self.conv_norm = conv_norm
self.pad_mode = pad_mode
Expand Down