Add accessible name to Control Alt Fill checkbox on Colors page#785
Open
mmanolova-msft wants to merge 1 commit into
Open
Add accessible name to Control Alt Fill checkbox on Colors page#785mmanolova-msft wants to merge 1 commit into
mmanolova-msft wants to merge 1 commit into
Conversation
The example checkbox in the 'Control Alt Fill' section of the WPF Gallery Colors page had no AutomationProperties.Name, so Narrator announced only its checked state and not its label. Adding an accessible name fixes the MAS 4.1.2 (Name, Role, Value) issue. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The example
CheckBoxin the Control Alt Fill section of the WPF Gallery Colors page (Design Guidance → Colors → Fill subpage) had no accessible name. As a result, Narrator announced only its checked state (e.g. "checkbox, checked") and not its label, violating MAS 4.1.2 (Name, Role, Value).This adds
AutomationProperties.Name="Control Alt Fill"so Narrator now announces "Control Alt Fill checkbox, checked".Repro
Before: Narrator reads only "checkbox, checked".
After: Narrator reads "Control Alt Fill checkbox, checked".
Fixes internal work item AB#3019259.
Microsoft Reviewers: Open in CodeFlow