Fix keyboard scrolling on Spacing design guidance page#789
Open
wnvko-msft wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Spacing page (Design Guidance) could not be scrolled with the keyboard. The
ScrollViewerwas not focusable and had no tab stop, so users could not Tab to the content or use Arrow / Page Up / Page Down keys to scroll.Changes
Focusable=TrueandIsTabStop=Trueon the SpacingPageScrollViewer, so it can receive keyboard focus and be scrolled via the keyboard.AutomationProperties.Namefor screen-reader context.Fixes #3018621.
Microsoft Reviewers: Open in CodeFlow