Skip to content

.NET: Mark Magentic Orchestration Experimental#5704

Merged
lokitoth merged 3 commits intomainfrom
dev/dotnet_workflow/mark_magentic_experimental
May 7, 2026
Merged

.NET: Mark Magentic Orchestration Experimental#5704
lokitoth merged 3 commits intomainfrom
dev/dotnet_workflow/mark_magentic_experimental

Conversation

@lokitoth
Copy link
Copy Markdown
Member

@lokitoth lokitoth commented May 7, 2026

Motivation and Context

Magentic Orchestration for .NET is newly implemented and will be undergoing stabilization over the following several weeks. This will communicate this status clearly for the duration, similar to Handoff Orchestration.

Description

Mark Magentic Orchestration [Experimental] for the duration of this process.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • [ ] Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

@lokitoth lokitoth self-assigned this May 7, 2026
Copilot AI review requested due to automatic review settings May 7, 2026 20:59
@lokitoth lokitoth added .NET agent orchestration Issues related to agent orchestration workflows Related to Workflows in agent-framework labels May 7, 2026
@lokitoth lokitoth moved this to In Progress in Agent Framework May 7, 2026
@lokitoth lokitoth enabled auto-merge May 7, 2026 21:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to communicate the stabilization status of the newly implemented .NET Magentic orchestration by marking its API as experimental, consistent with how Handoff orchestration is currently staged.

Changes:

  • Added System.Diagnostics.CodeAnalysis import to enable use of the [Experimental] attribute.
  • Marked MagenticWorkflowBuilder with [Experimental(DiagnosticConstants.ExperimentalFeatureDiagnostic)].

Comment thread dotnet/src/Microsoft.Agents.AI.Workflows/MagenticWorkflowBuilder.cs
@lokitoth lokitoth moved this from In Progress to In Review in Agent Framework May 7, 2026
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Code Review

Reviewers: 4 | Confidence: 95%

✓ Correctness

The change correctly adds the [Experimental] attribute to MagenticWorkflowBuilder, following the same pattern used for HandoffWorkflowBuilder. The using directive is properly added, and DiagnosticConstants.ExperimentalFeatureDiagnostic is defined as an internal constant in the same assembly (HandoffWorkflowBuilder.cs:19, value "MAAIW001"). No correctness issues found.

✓ Security Reliability

This PR adds the [Experimental] attribute to MagenticWorkflowBuilder, mirroring the existing pattern used for HandoffWorkflowBuilder and other classes. The change is purely a compile-time metadata annotation using the existing DiagnosticConstants.ExperimentalFeatureDiagnostic constant ("MAAIW001") and has no runtime security or reliability implications.

✓ Test Coverage

This PR adds the [Experimental] attribute to MagenticWorkflowBuilder, following the same pattern already used by HandoffWorkflowBuilder and other classes in the project. The change is purely a compile-time diagnostic annotation and does not alter runtime behavior. No tests in the repository verify the presence of [Experimental] attributes on any class (including the already-marked HandoffWorkflowBuilder), so the absence of such a test here is consistent with the established codebase convention. No test coverage concerns are introduced by this change.

✗ Design Approach

The change moves Magentic in the right direction, but it only marks the builder type as experimental. That leaves several other public Magentic-facing types unannotated, so consumers can still depend on the feature's plan-review and event contracts without seeing the experimental diagnostic. Given the PR rationale is to communicate the unstable status clearly, and the repo's handoff rollout marks the full exposed surface instead of just one builder type, I would request a broader annotation pass.

Flagged Issues

  • MagenticWorkflowBuilder is now marked experimental, but the rest of the public Magentic surface is still unannotated: MagenticPlanReviewRequest (MagenticPlanReviewRequest.cs:18), MagenticPlanReviewResponse (MagenticPlanReviewResponse.cs:15), MagenticProgressLedger (MagenticProgressLedger.cs:17), and the public Magentic event types (Specialized/Magentic/MagenticOrchestrator.cs:20,28,40,52). Consumers can still use these contracts without any experimental warning, which undercuts the stated goal. The existing handoff rollout shows the broader pattern: it marks both the builder and related types (HandoffWorkflowBuilder.cs:32-41, Specialized/HandoffMessagesFilter.cs:10,20).

Automated review by lokitoth's agents

Comment thread dotnet/src/Microsoft.Agents.AI.Workflows/MagenticWorkflowBuilder.cs
@lokitoth lokitoth added this pull request to the merge queue May 7, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 7, 2026
@lokitoth lokitoth added this pull request to the merge queue May 7, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 7, 2026
@lokitoth lokitoth added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit 27324a8 May 7, 2026
33 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent orchestration Issues related to agent orchestration .NET workflows Related to Workflows in agent-framework

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants