Skip to content

[HIGH] Patch kata-containers-cc for CVE-2025-5791 and [MEDIUM] CVE-2025-4574 - #14238

Closed
archana25-ms wants to merge 3 commits into
microsoft:fasttrack/3.0from
archana25-ms:topic_smalavathu_kata-containers-3.0
Closed

[HIGH] Patch kata-containers-cc for CVE-2025-5791 and [MEDIUM] CVE-2025-4574#14238
archana25-ms wants to merge 3 commits into
microsoft:fasttrack/3.0from
archana25-ms:topic_smalavathu_kata-containers-3.0

Conversation

@archana25-ms

@archana25-ms archana25-ms commented Jul 9, 2025

Copy link
Copy Markdown
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Patch kata-containers-cc for CVE-2025-5791 and CVE-2025-4574

Change Log
  • SPECS/kata-containers-cc/CVE-2025-4574.patch
  • SPECS/kata-containers-cc/CVE-2025-5791.patch
  • SPECS/kata-containers-cc/kata-containers-cc.spec
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

@aaruag

aaruag commented Jul 9, 2025

Copy link
Copy Markdown

/azurepipelines run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jslobodzian
jslobodzian requested a review from a team July 10, 2025 15:57
@aaruag

aaruag commented Jul 11, 2025

Copy link
Copy Markdown

/azurepipelines run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@aaruag

aaruag commented Jul 14, 2025

Copy link
Copy Markdown

/azurepipelines run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Comment thread SPECS/kata-containers-cc/kata-containers-cc.spec Outdated
Distribution: Azure Linux
Source0: https://github.com/microsoft/kata-containers/archive/refs/tags/%{version}.tar.gz#/%{sourceName}-%{version}.tar.gz
Source1: %{sourceName}-%{version}-cargo.tar.gz
Patch0: CVE-2025-4574.patch

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have an update to 3.18: #14105 - are those CVEs not fixed by this update? @Redent0r can you confirm?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ms-mahuber this is for kata-containers-cc, which will stay at 3.15 for the time being

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the policy is to fix CVEs at source level and increment the sources, rather than applying patch files on SPEC level.

Comment thread SPECS/kata-containers-cc/kata-containers-cc.spec
@manuelh-dev

Copy link
Copy Markdown

Can we please share build IDs for end-to-end tests in AKS?

@archana25-ms
archana25-ms force-pushed the topic_smalavathu_kata-containers-3.0 branch from 7100e50 to dd5cd88 Compare July 15, 2025 06:37
@archana25-ms
archana25-ms force-pushed the topic_smalavathu_kata-containers-3.0 branch from 5f59ca5 to b8a84d8 Compare July 15, 2025 06:39
@@ -0,0 +1,53 @@
From ff0fc156e62412d2cde3790d58fd121e48215953 Mon Sep 17 00:00:00 2001

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This CVE fix should be contributed to our fork. How would a fix in our fork look like?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the following packages:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ms-mahuber the users crate is a dependency pulled in from the direct dependency on fuser in Cargo.toml.
The fuser version in sources is 0.12.0. The 0.13.0 release removes dependency on users.

@@ -0,0 +1,35 @@
From 804b30dde9c5e95b794e08bd01c26464ede4933c Mon Sep 17 00:00:00 2001

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed upstream first if not yet done, then we can backport this into our fork or consume the fix through rebasing our sources against a new release

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is already fixed upstream resp. in our fork. For:

  • kata: The 3.18.0 release uses crossbeam-channel with 0.5.15
  • kata-cc: The 3.15.0 release still uses crossbeam-channel 0.5.14. Here, we should extend the release/3.15.0 branch to update the rust crate reference

@Sumynwa

Sumynwa commented Jul 23, 2025

Copy link
Copy Markdown

Will close this PR. @ms-mahuber @Redent0r
As discussed, will target the fixes in sources followed by a PR with bumped version for kata-containers-cc.

@Sumynwa Sumynwa closed this Jul 23, 2025
@Kanishk-Bansal

Copy link
Copy Markdown

merged and fixed at #17761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fasttrack/3.0 PRs Destined for Azure Linux 3.0 Packaging security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants