feat(ShellCheck): add ShellCheck 0.11.0 with ghc-Diff and ghc-fgl deps - #18318
Draft
liunan-ms wants to merge 1 commit into
Draft
feat(ShellCheck): add ShellCheck 0.11.0 with ghc-Diff and ghc-fgl deps#18318liunan-ms wants to merge 1 commit into
liunan-ms wants to merge 1 commit into
Conversation
Import ShellCheck 0.11.0 from Fedora 43 as a shell script analysis tool. Pull in its two previously-missing Haskell build dependencies, ghc-Diff 0.5 and ghc-fgl 5.8.3.0; all other BuildRequires are satisfied by the existing ghc compiler package and already-packaged ghc-* libraries. Built and smoke-tested in a mock chroot (shellcheck --version, lint of both a flawed and a clean script).
Contributor
There was a problem hiding this comment.
Pull request overview
Adds ShellCheck 0.11.0 and its missing Haskell dependencies as bare Fedora 43 components.
Changes:
- Registers ShellCheck, ghc-Diff, and ghc-fgl.
- Adds generated specs, sources, and lock files.
- Includes ghc-Diff’s revised Cabal metadata.
Reviewed changes
Copilot reviewed 8 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
base/comps/components.toml |
Registers three components. |
locks/ShellCheck.lock |
Pins ShellCheck upstream state. |
locks/ghc-Diff.lock |
Pins ghc-Diff upstream state. |
locks/ghc-fgl.lock |
Pins ghc-fgl upstream state. |
specs/s/ShellCheck/ShellCheck.spec |
Defines ShellCheck RPM packaging. |
specs/s/ShellCheck/sources |
Records ShellCheck source checksum. |
specs/g/ghc-Diff/ghc-Diff.spec |
Defines ghc-Diff RPM packaging. |
specs/g/ghc-Diff/Diff-0.5.cabal |
Supplies revised Cabal metadata. |
specs/g/ghc-Diff/sources |
Records ghc-Diff source checksum. |
specs/g/ghc-fgl/ghc-fgl.spec |
Defines ghc-fgl RPM packaging. |
specs/g/ghc-fgl/sources |
Records ghc-fgl source checksum. |
Member
|
@liunan-ms Great to see this coming through! This package has been long-requested 😄 Just a reminder that new package additions will require working with the team to get them allow-listed in our build services (koji) -- across dev and prod. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds ShellCheck 0.11.0 (shell script analysis tool) to Azure Linux 4.0, imported from Fedora 43 as a bare upstream component (no overlays required).
Two previously-missing Haskell build dependencies are pulled in alongside it:
ShellCheck/usr/bin/shellcheckghc-DiffBuildRequiresof ShellCheckghc-fglBuildRequiresof ShellCheckAll three are inline Fedora-43 imports in
base/comps/components.toml.Dependency analysis
ShellCheck's
BuildRequires:ghc-Cabal ghc-Diff ghc-QuickCheck ghc-aeson ghc-array ghc-base ghc-bytestring ghc-containers ghc-deepseq ghc-directory ghc-fgl ghc-filepath ghc-mtl ghc-parsec ghc-process ghc-regex-tdfa ghc-transformers+ghc-rpm-macros pandoc.Cabal, array, base, bytestring, containers, deepseq, directory, filepath, mtl, parsec, process, transformers, pretty) — already shipped by the existingghccompiler package.ghc-QuickCheck,ghc-aeson,ghc-regex-tdfa,ghc-rpm-macros,pandoc, plus transitivedos2unixandghc-hspec.ghc-Diff,ghc-fgl.Transitive deps of the two new components resolve entirely against existing packages.
Validation
ghc-Diff→ghc-fgl→ShellCheckbuilt cleanly, producingShellCheck-0.11.0-2.azl4.x86_64.rpm(+ghc-ShellChecklibrary subpackages).shellcheckresolves to/usr/bin/shellcheck.SC2154,SC2086) and exits non-zero.azldev comp updatereports locks up to date;azldev comp rendershows no spec drift after commit.