fix(ci): retry OpenCppCoverage install and fail if binary missing - #5529
Open
Vedant Madane (VedantMadane) wants to merge 1 commit into
Open
Vedant Madane (VedantMadane) wants to merge 1 commit into
Vedant Madane (VedantMadane) wants to merge 1 commit into
Conversation
The coverage install step could appear green when the silent installer did not actually leave OpenCppCoverage.exe on disk. Retry download+install a few times, require the binary path, and set ErrorActionPreference Stop so failures cannot be ignored. Fixes microsoft#5330 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
Vedant Madane (VedantMadane)
requested review from
Alan Jowett (Alan-Jowett),
Dave Thaler (dthaler),
Laksh (lakshk98) and
Matthew Ige (matthewige)
as code owners
August 23, 2026 22:27
| $installed = $false | ||
| for ($attempt = 1; $attempt -le $maxInstallAttempts; $attempt++) { | ||
| Write-Host "OpenCppCoverage install attempt $attempt of $maxInstallAttempts" | ||
| & $(Build.SourcesDirectory)\scripts\Download-AndVerify.ps1 -Url $url -DestinationPath $setupPath -ExpectedHash $expectedHash |
Contributor
There was a problem hiding this comment.
with $ErrorActionPreference set to stop, failures in any of the iterations would result in termination. Consider adding try catch to ensure actual retires.
| name: set_up_opencppcoverage | ||
| displayName: 'Set up OpenCppCoverage and add to PATH' | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Fixes #5330