feat: support async declarative template strings#7558
Draft
janechu wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Adds support for async declarative template strings in
declarativeTemplate({ callback }). The callback now receives atemplateStringResolverthat accepts astring | Promise<string>containing an<f-template>element and resolves it through the existing declarative template path.This also adds source-level coverage, an ecosystem
async-template-stringfixture, updated API/docs/website generated content, size docs, and a change file.👩💻 Reviewer Notes
Please focus review on the callback resolver semantics and diagnostic behavior: callbacks must return or await the resolver, and callbacks that complete without resolving now reject with a clear diagnostic instead of hanging.
Root
npm run testwas run. It fails only with unrelated Firefox caveats after exact reruns: the unmodified hydration Firefox failure (hydration.pw.spec.ts:179:5,element.$fastController is undefined) plus Firefox fixture flakes that pass on exact rerun/full fast-test-harness rerun.📑 Test Plan
npm cinpx playwright install --with-depsnpm run buildnpm run biome:checknpm run checkchangenpm run testwas run with the unrelated Firefox caveats noted above✅ Checklist
General
$ npm run change