fix: defer array observer reentrant notifications#7559
Open
janechu wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
b43340f to
1aa8dbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fix array observer notification delivery so mutations queued while subscribers are
being notified are deferred to the update queue instead of being flushed
reentrantly when a subscriber is added.
observed array and subscribes during notification.
notification.
Test Plan
npm run buildnpm run biome:checknpm run checkchangenpm run build:tsc -w @microsoft/fast-elementnpm run lint -w @microsoft/fast-elementnpm run testcurrently fails in unrelated@microsoft/fast-test-harnessFirefox fixture timeouts in this local environment.
Checklist
General
$ npm run change