Refresh commitment discount eligibility open data - #2278
Open
Roland Krummenacher (RolandKrummenacher) wants to merge 1 commit into
Open
Refresh commitment discount eligibility open data#2278Roland Krummenacher (RolandKrummenacher) wants to merge 1 commit into
Roland Krummenacher (RolandKrummenacher) wants to merge 1 commit into
Conversation
Roland Krummenacher (RolandKrummenacher)
requested a review
from Michael Flanakin (flanakin)
as a code owner
August 24, 2026 10:54
Roland Krummenacher (RolandKrummenacher)
requested a review
from Brett Wilson (MSBrett)
as a code owner
August 24, 2026 10:54
microsoft-github-policy-service
Bot
added
Tool: Open data
Copilot started reviewing on behalf of
Roland Krummenacher (RolandKrummenacher)
August 24, 2026 10:54
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refreshes the Commitment discount eligibility open-data sidecar (familycounts.json) with updated per–service family meter counts, reflecting the first successful run of the rewritten fetch workflow (per PR description).
Changes:
- Update the Reservation family counts to match the latest published eligibility results.
- Update the Consumption family counts (including changes in Compute/Containers/Databases and other categories) to match the latest run output.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Refreshes the Commitment discount eligibility open data with the first successful run of the rewritten fetch script from #2251.
The dataset had not changed since it first shipped in v14, because the weekly job hit its 60-minute timeout before it could publish. #2251 merged this morning (
a7ab9194). Today's scheduled run at 06:21 UTC still used the old code and was killed at 1h 00m 09s. This branch comes from a manual dispatch after the merge.Generated by run 32717800666 (
workflow_dispatch,ref=dev,dry_run=false, 14m 08s).Verification
The new two-traversal completeness check passed with zero drift on both price types:
The historical guard also passed: 92,624 meters seen this run against 92,282 cached.
Change summary
Reproducibility
A dry run (32716230110, 17m 24s) ran 18 minutes before this one and produced identical numbers in every field — same item counts, same page counts, same eligible-meter counts, same add/change/remove totals. Non-reproducibility was the original fault, so this is the result worth recording.
📋 Checklist
🔬 How did you test this change?
📦 Deploy to test?
🙋♀️ Do any of the following that apply?