-
Notifications
You must be signed in to change notification settings - Fork 809
feat(react-icons-atomic-webpack-loader): add export-level atomization #1246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Martin Hochel (Hotell)
wants to merge
14
commits into
microsoft:main
Choose a base branch
from
Hotell:feat/export-level-atomizer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
cc2bf96
feat(react-icons): add export-level atomization
Hotell 671d009
fix(react-icons): harden export-level atomization
Hotell 2182321
test(react-icons): address atomizer review feedback
Hotell 617056d
fix(react-icons): use typed source map composition
Hotell 4140e2f
refactor(react-icons): isolate source map composition
Hotell 86a8c3a
test(react-icons): clarify loader benchmark output
Hotell 90b285f
fix(react-icons): restore jridgewell remapping
Hotell 14346f2
test(react-icons): scale atomizer benchmark
Hotell 71f2e69
docs(react-icons): explain icon chunk granularity
Hotell 7225367
feat(atomic-loader): harden selector protocol contract
Hotell a6255a5
refactor(atomic-loader): isolate icon granularity changes
Hotell 93a5e83
test(svg-sprites): isolate icon granularity coverage
Hotell 8c7d723
fix(atomic-loader): honor disabled source maps
Hotell 8109089
docs(react-icons): document scoped icon granularity
Hotell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
packages/react-icons-atomic-webpack-loader/src/direct-path.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import { getIconFamilyName } from './selector-protocol'; | ||
|
|
||
| export interface DirectIconPath { | ||
| family: string; | ||
| variant: 'svg' | 'fonts' | 'svg-sprite'; | ||
| } | ||
|
|
||
| export function classifyDirectIconPath(request: string): DirectIconPath | null { | ||
| const match = /^@fluentui\/(react-icons|react-brand-icons)\/(headless\/)?(svg|fonts|svg-sprite)\/([\w-]+)$/.exec( | ||
| request, | ||
| ); | ||
| if (!match) { | ||
| return null; | ||
| } | ||
|
|
||
| const [, packageName, headless, variant, family] = match; | ||
| if (packageName === 'react-brand-icons' && variant !== 'svg') { | ||
| return null; | ||
| } | ||
| if (headless && variant === 'svg-sprite') { | ||
| return null; | ||
| } | ||
| return { family, variant: variant as DirectIconPath['variant'] }; | ||
| } | ||
|
|
||
| export function belongsToDirectIconPath(exportName: string, directPath: DirectIconPath): boolean { | ||
| return getIconFamilyName(exportName) === directPath.family; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.