Fixes around CU copies and delete deadlocks - #2082
Merged
kevin-montrose merged 3 commits intoAug 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Vector Set copy updates and removes blocking deletion waits.
Changes:
- Limits copy updates to the requested size.
- Makes deletion marking asynchronous.
- Updates deletion documentation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
website/docs/dev/vector-sets.md |
Updates deletion workflow docs. |
VectorSessionFunctions.cs |
Bounds copy-update spans. |
VectorManager.cs |
Removes synchronous cleanup wait. |
VectorManager.Cleanup.cs |
Simplifies asynchronous cleanup requests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Tiago Nápoli (tiagonapoli)
approved these changes
Aug 24, 2026
kevin-montrose
deleted the
users/kmontrose/vectorSessionFunctionSizingFixes
branch
August 24, 2026 17:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes:
VectorSessionFunctions.CopyUpdaterdoesn't copy extra data (which can result in a span length check failing)