feat(wta): show all session origins in session management picker#253
Draft
DDKinger wants to merge 1 commit into
Draft
feat(wta): show all session origins in session management picker#253DDKinger wants to merge 1 commit into
DDKinger wants to merge 1 commit into
Conversation
The /sessions picker shipped in MVP mode showing only Class B (shell-pane) sessions, hiding Class A (agent-pane) sessions WTA spawned for an Intelligent Terminal agent pane. Both classes already route correctly through session_mgmt::decide_enter_action, so there is no reason to keep agent-pane sessions out of the picker. Flip the picker default to OriginFilter::All (DEFAULT_SESSIONS_ORIGIN_FILTER, replacing MVP_SESSIONS_ORIGIN_FILTER) and remove the WTA_SESSIONS_SHOW_AGENT_PANE env-override resolver + its test. The OriginFilter axis, App::sessions_origin_filter field, and 'wta sessions list --origin' CLI slicing are all preserved; only the default changes. Docs/comments updated accordingly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WTA /sessions session-management picker to show sessions from all origins by default (both shell-pane “Class B” sessions and agent-pane “Class A” sessions), aligning the picker’s default behavior with the existing routing support in session_mgmt::decide_enter_action.
Changes:
- Switch the
/sessionspicker default origin filter from “shell only” toOriginFilter::All, removing the prior MVP-only gate and itsWTA_SESSIONS_SHOW_AGENT_PANEenv override. - Update CLI/docs/comments to reflect that
allis the default and that--origin shell|agent-paneremains available for slicing. - Remove the env-override test and adjust session-origin filter tests to explicitly set filters where needed.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/wta/src/app.rs | Changes the picker’s default origin filter to All and removes the env-based override plumbing and test coverage for it. |
| tools/wta/src/agent_sessions.rs | Updates origin-filter documentation to match the new picker default and clarify CLI slicing behavior. |
| tools/wta/src/ui/agents_view.rs | Updates UI-layer comments to reference the new default and constant naming. |
| tools/wta/src/main.rs | Updates wta sessions list help text/comments to reflect that /sessions now defaults to all. |
| tools/wta/src/cli_tests.rs | Updates CLI parsing test commentary to align with the picker default and origin slicing story. |
| tools/wta/AGENTS.md | Updates design/behavior documentation to state the picker now surfaces all session origins and removes the obsolete env override guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/sessionssession-management picker shipped in ""MVP"" mode that surfaced only Class B (shell-pane) sessions — the user manually rancopilot/claude/geminiin a regular shell — and hid Class A (agent-pane) sessions that WTA spawned on behalf of an Intelligent Terminal agent pane. Both classes already route correctly throughsession_mgmt::decide_enter_action, so there's no reason to keep agent-pane sessions out of the picker.This PR makes the picker show all session origins.
Changes
app.rs— Replace theMVP_SESSIONS_ORIGIN_FILTER(ShellOnly) constant and theresolve_sessions_origin_filter()env-override resolver withDEFAULT_SESSIONS_ORIGIN_FILTER = OriginFilter::All; the field is initialized to it directly. Remove the obsoleteWTA_SESSIONS_SHOW_AGENT_PANEenv-override and its test.agent_sessions.rs/main.rs/cli_tests.rs/ui/agents_view.rs/tools/wta/AGENTS.md— Update doc comments to reflect the new default.The
OriginFilteraxis, theApp::sessions_origin_filterfield, andwta sessions list --origin shell|agent-pane|allslicing are all preserved — only the picker's default changes. No Enter/Shift+Enter dispatch logic needed to change.Verification
cargo build— succeedscargo test— 711 passed, 0 failed