Two phase cleanup for Listener Objects#6075
Open
Santhosha-bk wants to merge 3 commits into
Open
Conversation
guhetier
reviewed
Jun 8, 2026
guhetier
reviewed
Jun 8, 2026
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (36.36%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6075 +/- ##
==========================================
- Coverage 85.93% 84.69% -1.25%
==========================================
Files 60 60
Lines 18798 18847 +49
==========================================
- Hits 16155 15963 -192
- Misses 2643 2884 +241 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
guhetier
previously approved these changes
Jun 11, 2026
guhetier
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed registration shutdown listener race by safely snapshotting listeners before stopping them.
During registration shutdown, listeners are now drained from the shared registration list under lock, and each listener is conditionally pinned with a non-zero refcount acquire. Only successfully pinned listeners are moved to a private pending list, then stopped outside the lock and released afterward.
This prevents shutdown from touching listeners that concurrently reached refcount zero, avoids stale-list traversal risks, and keeps listener lifetime handling safe under concurrent close/shutdown interleaving's.
Fixes : https://microsoft.visualstudio.com/OS/_workitems/edit/61981303/
Testing
Documentation
N/A