[CP] Virtual buffer overflow fix (#6022)#6084
Open
guhetier wants to merge 2 commits into
Open
Conversation
guhetier
commented
Jun 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/2.4 #6084 +/- ##
===============================================
+ Coverage 86.08% 86.83% +0.75%
===============================================
Files 56 56
Lines 17341 17343 +2
===============================================
+ Hits 14928 15060 +132
+ Misses 2413 2283 -130 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
## Description Changed guard condition to fix virtual buffer issue.. ## Testing NA ## Documentation NA
guhetier
force-pushed
the
guhetier/cp_virtual_buffer_overflow_2_4_copilot
branch
from
ddef9f9 to
fb7208e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed guard condition to fix virtual buffer issue: added
VirtualBufferLength != 0check and clamped doubled length toUINT32_MAXvia a newNewLengthlocal.Conflict resolution note: on
release/2.4, the trace log call (IncreaseRxBuffer) appears beforeQuicRecvBufferIncreaseVirtualBufferLength(opposite order frommain). The existing 2.4 ordering was preserved; only the fix itself (guard, clamp, and(uint32_t)NewLengthin both call sites) was applied. The auto-merge ofsrc/generated/linux/stream_recv.c.clog.h*from the original commit was kept as-is.Testing
CI
Documentation
No documentation impact.