fix(chart): default agent and operator images to ghcr.io - #2591
fix(chart): default agent and operator images to ghcr.io#2591Rémi BUISSON (darkweaver87) wants to merge 4 commits into
Conversation
| repository: acndev.azurecr.io/retina-operator | ||
| repository: ghcr.io/microsoft/retina/retina-operator | ||
| pullPolicy: Always | ||
| tag: "latest" |
There was a problem hiding this comment.
I don't think we've ever published latest tags for any images, we should pin this to a released version tag
There was a problem hiding this comment.
Good catch — done. The three Retina image tags now default to .Chart.Version (the released chart version, e.g. v1.2.3) when left empty, instead of latest; --set <image>.tag=… still overrides. Verified with helm package --version + helm template — which is exactly what release-charts.yaml (L55-56) does, so the published chart's .Chart.Version is the release tag.
Quang Nguyen (nddq)
left a comment
Quang Nguyen (nddq)
left a comment
There was a problem hiding this comment.
We should expand this fix to the default charts as well, since they are being hardcoded to v0.0.2.
| pullPolicy: Always | ||
| tag: "latest" | ||
| # -- Image tag; when empty, defaults to the chart version (the released version). | ||
| tag: "" |
There was a problem hiding this comment.
nit: .Chart.Version is only the release tag for the packaged chart, since we don't update those, from a source-tree install it is still 0.0.1, so helm install ./deploy/hubble/... renders retina-agent:0.0.1. I'd say "the chart version" and drop the parenthetical.
| repository: acndev.azurecr.io/retina-agent | ||
| tag: "latest" | ||
| repository: ghcr.io/microsoft/retina/retina-agent | ||
| tag: "" |
There was a problem hiding this comment.
we can mirror the comments for the retina-operator's tag here as well + agent-init
| enabled: true | ||
| name: retina-agent-init | ||
| repository: ghcr.io/microsoft/retina/retina-init | ||
|
|
There was a problem hiding this comment.
drop this whitespace
| enabled: true | ||
| name: retina-agent-init | ||
| repository: ghcr.io/microsoft/retina/retina-init | ||
|
|
1f76919 to
6047ab3
Compare
|
Quang Nguyen (@nddq) thanks for your review. I addressed your comments :-) |
Signed-off-by: darkweaver87 <remi-buisson@orange.fr>
… latest Signed-off-by: darkweaver87 <remi-buisson@orange.fr>
Signed-off-by: darkweaver87 <remi-buisson@orange.fr>
Signed-off-by: darkweaver87 <remi-buisson@orange.fr>
6047ab3 to
ccb0e59
Compare
| # Overrides the image tag whose default is the chart appVersion. | ||
| tag: "v0.0.2" | ||
| # -- Image tag; when empty, defaults to the chart version. | ||
| tag: "" |
There was a problem hiding this comment.
This regresses the source-tree install. Chart.yaml is still 0.0.1, so helm install retina ./deploy/standard/manifests/controller/helm/retina/ renders retina-agent:0.0.1. The registry returns 404 for that tag and 200 for v0.0.2. docs/04-Captures/04-managed-storage-account.md L59 uses that local path with no tag override, so it now ends in ImagePullBackOff.
Let's point it at the published chart instead:
-helm upgrade --install retina ./deploy/standard/manifests/controller/helm/retina/ \
+VERSION=$( curl -sL https://api.github.com/repos/microsoft/retina/releases/latest | jq -r .name)
+helm upgrade --install retina oci://ghcr.io/microsoft/retina/charts/retina \
+ --version $VERSION \
--set operator.enabled=true \templates/NOTES.txt L1 points at the same local path. That one is pre-existing, so a follow-up is fine.
| enabled: true | ||
| replicas: 1 | ||
| repository: acndev.azurecr.io/retina-operator | ||
| repository: ghcr.io/microsoft/retina/retina-operator |
There was a problem hiding this comment.
The Hubble block in docs/02-Installation/01-Setup.md still sets three repositories that now match the defaults. I rendered the packaged chart with and without those flags. The output is identical. Let's drop L133, L136 and L139:
--set operator.enabled=true \
- --set operator.repository=ghcr.io/microsoft/retina/retina-operator \
--set operator.tag=$VERSION \
--set agent.enabled=true \
- --set agent.repository=ghcr.io/microsoft/retina/retina-agent \
--set agent.tag=$VERSION \
--set agent.init.enabled=true \
- --set agent.init.repository=ghcr.io/microsoft/retina/retina-init \
--set agent.init.tag=$VERSION \The --set *.tag=$VERSION lines are dead now too, in both charts' blocks. That sweep is larger, so a follow-up is fine.
2 participants
Motivation
The retina-hubble chart defaults the agent and operator images to
acndev.azurecr.io, an internal registry that isn't reachable outside Microsoft, so a stockhelm installof the published chart lands inImagePullBackOff. Theretina-initimage, and thestandardchart's agent/operator, already default toghcr.io/microsoft/retina/*; this aligns the hubble chart with them. Only the two default repositories change — rendered output is otherwise identical.