Skip to content

[main] Update dependencies from microsoft/testfx - #12300

Merged
github-actions[bot] merged 2 commits into
mainfrom
darc-main-13d774c8-2d06-42f8-9cbd-0dbce56f4a8e
Nov 10, 2026
Merged

github-actions[bot] merged 2 commits into
mainfrom
darc-main-13d774c8-2d06-42f8-9cbd-0dbce56f4a8e

Conversation

@dotnet-maestro

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/microsoft/testfx

…261109.7

On relative base path root
Microsoft.Testing.Platform From Version 3.0.0-preview.26556.8 -> To Version 3.0.0-preview.26559.7
MSTest From Version 5.0.0-preview.26556.8 -> To Version 5.0.0-preview.26559.7
Copilot AI balanced review requested due to automatic review settings November 10, 2026 02:02
@github-actions
github-actions Bot enabled auto-merge (squash) November 10, 2026 02:02
@github-actions github-actions Bot added the state/needs-review Awaiting review from the team. label Nov 10, 2026

@microsoft-github-policy-service microsoft-github-policy-service Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approve

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the MSTest and Microsoft.Testing.Platform dependency update.

No open issues 🎉

What changed in this PR

Updates the repository’s MSTest and Microsoft.Testing.Platform dependencies to the November 9 upstream build, keeping version properties and dependency provenance aligned.

Changes:

  • Updates MSTest to 5.0.0-preview.26559.7 and Microsoft.Testing.Platform to 3.0.0-preview.26559.7.
  • Updates both dependency commit references to cb5805342d403ed9f7e7ddd116c81fee789ef7f9.
File Description
eng/​Versions.props Updates the MSTest and Microsoft.Testing.Platform version properties.
eng/​Version.Details.xml Records matching dependency versions and upstream commit references.

Review effort: Balanced

Copilot AI commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Build the repository

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

@github-actions

Copy link
Copy Markdown
Contributor

Final test-triage resolution — Azure Pipelines build 1672135

Triggering check: microsoft.testfx (Build Windows Release).

Resolution: no test failure to triage. This leg failed in the Build task with compile-time analyzer errors (IDE0004: Cast is redundant), for example in:

  • TestHostExecutionOrchestratorMiddlewarePipelineTests.cs (line 729)
  • TestHostControllersTestHostFinalizationTests.cs (line 418)
  • MtpServerClientInProcessTests.cs (lines 76 and 340)

The build stopped before any tests ran. The normalized test results, retry history, crash/hang diagnostics and historical data are all empty. The evidence is complete (evidenceIncomplete=false), so this is not a test, flakiness, crash or slowness problem.

Next step: remove the redundant casts at the reported locations, then rebuild. Ordinary build failures are owned by Build Failure Analysis, not this triage. No issue was created.

🤖 Automated content by GitHub Copilot. Generated by the Pipeline Test Triage workflow. · copilot · auto · ~24 AIC · ⌖ ~1 AIC · ⊞ 10.1K

Remove redundant object casts and stale compatibility comments after the Assert.IsNotNull API revert flows into the test dependencies.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 10, 2026 10:49
@github-actions github-actions Bot added state/approved Proposal approved; ready for implementation. and removed state/needs-review Awaiting review from the team. labels Nov 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

No open issues 🎉

Review effort: Lite

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Test quality review — PR #12300

Compared merge base ebe065a133d6beac1b57e72f6419f21595c8577b with head ec207e9caffda8b68fac1a2c3f2d5c7a3f9063ee. Evidence applies to this head, not every intermediate commit.

Test-value evidence

Contract Scenario / oracle Test / assertion Counterfactual Status
MSTest/MTP preview bump (eng/Versions.props, Version.Details.xml) Dependency version change; no behavior authored in repo n/a n/a Not applicable (dependency update)
Assert.IsNotNull((object?)x) → Assert.IsNotNull(x) in 4 places Behavior-preserving; the new MSTest IsNotNull overload makes the object cast workaround unnecessary. Same null check, same oracle. ShutdownServer_CancellationRegistration_UsesOnlyTheRemainingVi..., LaunchInProcessAsync_CallbackIsCanceledBeforeConnecting_Preser..., ControllerIpc_UnsupportedRequestReachesFailFastAndRethrowsOrig..., RunAsync_NestedMiddlewareFault_DelayedAncestorCancellationStil... Refactor: expected to pass before and after; null value would fail both forms Static prediction only; compilation against 5.0.0-preview.26559.7 not executed here

No execution records were inspected; no red/green claim is made.

🧵 Parallel safety

STATUS: CLEAN (no assemblies with parallelization configuration changes; no changed lifecycle/shared-state code). The specialist's CLEAN rests on the change description rather than a line-by-line read, but the diff is four single-line assertion edits with no shared state, resource, or ordering impact.

Per-test assessment

Pseudo-mutation evidence below consists of static predictions, not executed mutation results.

Result Quality Test Notes How to improve
Pass A (90–100) mod MtpServerClientInProcessTests.ShutdownServer_CancellationRegistration_UsesOnlyTheRemainingVirtualTimeBudget Only the null-check call form changed; assertion intent is unchanged. None
Pass A (90–100) mod MtpServerClientInProcessTests.LaunchInProcessAsync_CallbackIsCanceledBeforeConnecting_Preserves... Only the null-check call form changed; sibling assertions still pin message. None
Pass A (90–100) mod TestHostControllersTestHostFinalizationTests.ControllerIpc_UnsupportedRequestReachesFailFastAndRethrowsOriginal... Only the null-check call form changed; null-check precedes use of peer. None
Pass A (90–100) mod TestHostExecutionOrchestratorMiddlewarePipelineTests.RunAsync_NestedMiddlewareFault_DelayedAncestorCancellationStillReachesLeaf Only the null-check call form changed; guards outerDownstream before use. None

Test method names are abbreviated where the full name could not be fully confirmed from the diff hunk headers; no inline findings were warranted.

<sub>This advisory review is heuristic and non-blocking.

Re-run the combined review with /review-tests, or only the parallel-safety specialist with /parallel-audit.</sub>

🤖 Automated content by GitHub Copilot. Generated by the Test Quality Review on PR (on open / sync) workflow. · copilot · auto · ~46 AIC · ⌖ ~1 AIC · ⊞ 8.1K

@microsoft-github-policy-service microsoft-github-policy-service Bot added the state/needs-review Awaiting review from the team. label Nov 10, 2026
@github-actions github-actions Bot added state/approved Proposal approved; ready for implementation. and removed state/needs-review Awaiting review from the team. state/approved Proposal approved; ready for implementation. labels Nov 10, 2026
@github-actions
github-actions Bot merged commit 1629d41 into main Nov 10, 2026
55 of 60 checks passed
@github-actions
github-actions Bot deleted the darc-main-13d774c8-2d06-42f8-9cbd-0dbce56f4a8e branch November 10, 2026 12:32
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the state/approved Proposal approved; ready for implementation. label Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants