Skip to content

[curl] Fix usage of curl library on Android.#17400

Closed
AenBleidd wants to merge 1 commit into
microsoft:masterfrom
AenBleidd:vko_fix_curl_android_usage
Closed

[curl] Fix usage of curl library on Android.#17400
AenBleidd wants to merge 1 commit into
microsoft:masterfrom
AenBleidd:vko_fix_curl_android_usage

Conversation

@AenBleidd
Copy link
Copy Markdown
Contributor

Remove hard dependency on dynamically built OpenSSL.

Signed-off-by: Vitalii Koshura lestat.de.lionkur@gmail.com

Remove hard dependency on dynamically built OpenSSL.

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@JackBoosY JackBoosY added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label Apr 21, 2021
@ahmedyarub
Copy link
Copy Markdown

These hard-coded dependencies were copied from AWS SDK for C++. Removing them would break building on Windows.

@AenBleidd
Copy link
Copy Markdown
Contributor Author

@ahmedyarub, these lines are specific to Android.
#17418 might be more proper fix for this

@ahmedyarub
Copy link
Copy Markdown

@ahmedyarub, these lines are specific to Android.
#17418 might be more proper fix for this

Exactly! I've just tested that PR on Windows and it worked for compiling Android apps.

@AenBleidd
Copy link
Copy Markdown
Contributor Author

Closing this in favor of #17418

@AenBleidd AenBleidd closed this Apr 22, 2021
@AenBleidd AenBleidd deleted the vko_fix_curl_android_usage branch April 22, 2021 08:30
@AenBleidd AenBleidd restored the vko_fix_curl_android_usage branch April 22, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants