Skip to content

[netcdf-c] Fix build under Linux with dynamic linkage #19981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BillyONeal merged 4 commits into from
Sep 14, 2021
Merged

[netcdf-c] Fix build under Linux with dynamic linkage #19981

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
467b24e
[netcdf-c] Fix build under Linux with dynamic linkage
Osyotr Sep 3, 2021
50972b1
Merge remote-tracking branch 'origin/master' into HEAD
BillyONeal Sep 13, 2021
d23a62a
Add delete bin on *nix comment.
BillyONeal Sep 13, 2021
80fd8a4
Don't mark semver for unverified-semver port.
BillyONeal Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ports/netcdf-c/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ if("tools" IN_LIST FEATURES)
TOOL_NAMES nccopy ncdump ncgen ncgen3
AUTO_CLEAN
)
elseif(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
elseif(VCPKG_LIBRARY_LINKAGE STREQUAL "static" OR NOT VCPKG_TARGET_IS_WINDOWS)
Comment thread
BillyONeal marked this conversation as resolved.
# delete bin under non-windows because the dynamic libraries get put in lib
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/bin" "${CURRENT_PACKAGES_DIR}/bin")
endif()

Expand Down
4 changes: 2 additions & 2 deletions ports/netcdf-c/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "netcdf-c",
"version-string": "4.7.4",
"port-version": 3,
"version-semver": "4.7.4",
Comment thread
BillyONeal marked this conversation as resolved.
Outdated
"port-version": 4,
"description": "A set of self-describing, machine-independent data formats that support the creation, access, and sharing of array-oriented scientific data.",
"homepage": "https://github.com/Unidata/netcdf-c",
"dependencies": [
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4438,7 +4438,7 @@
},
"netcdf-c": {
"baseline": "4.7.4",
"port-version": 3
"port-version": 4
},
"netcdf-cxx4": {
"baseline": "4.3.1",
Expand Down
5 changes: 5 additions & 0 deletions versions/n-/netcdf-c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "0cf65dda2587f96fe1224d2af4abc436abcbe390",
"version-semver": "4.7.4",
"port-version": 4
},
{
"git-tree": "069ccb40f8ce75d6ec88b8fe31966c11fcf6906b",
"version-string": "4.7.4",
Expand Down