Skip to content

support hsml - #190

Closed
Shinigami (Shinigami92) wants to merge 1 commit into
microsoft:mainfrom
Shinigami92:support-hsml
Closed

support hsml#190
Shinigami (Shinigami92) wants to merge 1 commit into
microsoft:mainfrom
Shinigami92:support-hsml

Conversation

@Shinigami92

Copy link
Copy Markdown

I would like to add support for my hsml language (https://github.com/hsml-lab) which is very similar to pug
so this is right now nearly a 99% copy of the pug code, but adopted for hsml
I'm currently trying to bring syntax highlighting for it
Already did some work here: hsml-lab/vscode-hsml#17
but markdown is just pure white right now

@Shinigami92

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@mjbvz

Copy link
Copy Markdown
Contributor

Change looks good but I don't know if that language has enough usage yet to be included in our core grammar

However this repo shows how you can contribute this syntax highlighting from a VS Code extension: https://github.com/mjbvz/vscode-fenced-code-block-grammar-injection-example

From the user's point of view this should work exactly the same as if this PR was merged in

@Shinigami92

Copy link
Copy Markdown
Author

Change looks good but I don't know if that language has enough usage yet to be included in our core grammar

However this repo shows how you can contribute this syntax highlighting from a VS Code extension: mjbvz/vscode-fenced-code-block-grammar-injection-example

From the user's point of view this should work exactly the same as if this PR was merged in

Matt Bierner (@mjbvz) I understand your point about low usage, but it is a 🐔 <-> 🥚 problem: no big usage when no good UX

However, thanks for hinting me into fenced code block grammar, but I already tried this and even already pinged you there nearly 2 month ago 😅

Please help me to move forward there: hsml-lab/vscode-hsml#26 (comment)

@mjbvz

Copy link
Copy Markdown
Contributor

What did you try? The comment just says it didn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants