CCR feedback from PR view disappearing - #8882
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents the review state validator from clearing an explicitly selected pull request while an explicit PR checkout is still in progress (when the destination branch name hasn’t been determined yet), which could cause PR-related UI state (including CCR feedback) to disappear mid-checkout.
Changes:
- Add an early-return guard in
ReviewManager.validateStateto preserve the explicitly switched PR selection during an in-progress checkout. - Add a regression test covering the overlap between
validateStateand an explicit checkout (simulated by delayingupdateRepositoriesresolution).
Show a summary per file
| File | Description |
|---|---|
| src/view/reviewManager.ts | Adds a guard to avoid clearing the explicitly selected PR while checkout is in progress and the target branch is not yet known. |
| src/test/view/reviewManager.test.ts | Adds a regression test to ensure explicit PR selection isn’t lost when validation overlaps checkout. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
Vritant Bhardwaj (vritant24)
approved these changes
Aug 10, 2026
Anthony Kim (anthonykim1)
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.